Java object factory: allocate fixed length arrays #839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces the variable-length arrays produced by the Java object factory with fixed-length ones annotated with a variable length member. This allows the backend to use the much cheaper fixed-length array lowering rather than the full variable-length array theory, while retaining the ability for the effective length to vary. In effect this creates a bounded- length array construct. Fixes diffblue#746
tautschnig
reviewed
Apr 18, 2017
| @@ -386,6 +386,7 @@ void java_object_factoryt::gen_nondet_array_init( | |||
|
|
|||
| side_effect_exprt java_new_array(ID_java_new_array, expr.type()); | |||
| java_new_array.copy_to_operands(length_sym_expr); | |||
| java_new_array.set(ID_length_upper_bound, max_length_expr); | |||
There was a problem hiding this comment.
Couldn't we then also get rid of other bits of code using max_length_expr?
There was a problem hiding this comment.
length_sym_expr? No, the idea is that length_sym_expr is the actual size of the array and max_length_expr is the upper bound on that length. The actual size is used to initialise the array with NONDET members, and the bound is used to allocate the storage and provide a bound on the initialisation loop.
tautschnig
approved these changes
Apr 18, 2017
peterschrammel
approved these changes
Apr 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the variable-length arrays produced by the Java object factory with fixed-length ones annotated with a variable length member. This allows the backend to use the much cheaper fixed-length array lowering rather than the full variable-length array theory, while retaining the ability for the effective length to vary. In effect this creates a bounded-length array construct.
Fixes #746