Correcting addition of symbol to symbol map #837
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allredj
force-pushed
the
string-solver-bugfix-symbol-map
branch
from
e5ff09d to
2a3fcdc
Compare
allredj
changed the title
peterschrammel
approved these changes
Apr 18, 2017
peterschrammel
requested changes
Apr 18, 2017
| @@ -187,7 +187,7 @@ void string_refinementt::add_symbol_to_symbol_map( | |||
| symbol_resolve[lhs]=new_rhs; | |||
| reverse_symbol_resolve[new_rhs].push_back(lhs); | |||
|
|
|||
| std::list<exprt> symbols_to_update_with_new_rhs(reverse_symbol_resolve[rhs]); | |||
| std::list<exprt> symbols_to_update_with_new_rhs(reverse_symbol_resolve[lhs]); | |||
There was a problem hiding this comment.
Indeed, the copy is not necessary. I just pushed the correction.
| @@ -187,7 +187,7 @@ void string_refinementt::add_symbol_to_symbol_map( | |||
| symbol_resolve[lhs]=new_rhs; | |||
| reverse_symbol_resolve[new_rhs].push_back(lhs); | |||
|
|
|||
| std::list<exprt> symbols_to_update_with_new_rhs(reverse_symbol_resolve[rhs]); | |||
| std::list<exprt> symbols_to_update_with_new_rhs(reverse_symbol_resolve[lhs]); | |||
| for(exprt item : symbols_to_update_with_new_rhs) | |||
allredj
force-pushed
the
string-solver-bugfix-symbol-map
branch
from
2a3fcdc to
d731b75
Compare
smowton
reviewed
Apr 28, 2017
| @@ -187,7 +187,8 @@ void string_refinementt::add_symbol_to_symbol_map( | |||
| symbol_resolve[lhs]=new_rhs; | |||
| reverse_symbol_resolve[new_rhs].push_back(lhs); | |||
|
|
|||
| std::list<exprt> symbols_to_update_with_new_rhs(reverse_symbol_resolve[rhs]); | |||
| const std::list<exprt> | |||
There was a problem hiding this comment.
That looks a bit weird. I'd rather break after the ( or use assignment notation and break after =.
There was a problem hiding this comment.
Modified to break after (.
allredj
force-pushed
the
string-solver-bugfix-symbol-map
branch
from
d731b75 to
9513ff5
Compare
|
@peterschrammel does this PR look OK to you? |
peterschrammel
previously approved these changes
May 22, 2017
allredj
force-pushed
the
string-solver-bugfix-symbol-map
branch
from
9513ff5 to
3e8a945
Compare
There was a mistake that could cause looping over symbols in the map that don't actually need to be modified and could greatly slow down the analysis. Correction after review from Peter Schrammel: Use const reference for symbols_to_update_wit_new_rhs
allredj
force-pushed
the
string-solver-bugfix-symbol-map
branch
from
3e8a945 to
eb9a789
Compare
peterschrammel
approved these changes
Jun 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a mistake that could cause looping over symbols in the map that don't actually need to be modified and could greatly slow down the analysis.