Skip to content

Replace expired key for signing the MSI Installer #8364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

JohnLBergqvist
Copy link
Contributor

@JohnLBergqvist JohnLBergqvist commented Jul 1, 2024

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@JohnLBergqvist JohnLBergqvist force-pushed the update-expired-signing-key-for-msi-installer branch 5 times, most recently from 6537ab3 to 2595d0e Compare July 1, 2024 11:05
…ure Key Vault

This change was made because the previous PFX certificate has expired, and the private portion of newly issued code-signing certificates must reside on a HSM-backed solution, such as Azure Key Vault
The new certificate used is maintained by Diffblue in an HSM-compliant Azure Key Vault
@JohnLBergqvist JohnLBergqvist force-pushed the update-expired-signing-key-for-msi-installer branch from 2595d0e to 7460da8 Compare July 1, 2024 11:07
@JohnLBergqvist JohnLBergqvist changed the title Update expired key for signing the MSI Installer Replace expired key for signing the MSI Installer Jul 1, 2024
@JohnLBergqvist JohnLBergqvist marked this pull request as ready for review July 1, 2024 11:09
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.36%. Comparing base (582aa69) to head (7460da8).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8364      +/-   ##
===========================================
+ Coverage    78.28%   78.36%   +0.08%     
===========================================
  Files         1726     1726              
  Lines       188577   188382     -195     
  Branches     18443    18240     -203     
===========================================
  Hits        147629   147629              
+ Misses       40948    40753     -195     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JohnLBergqvist JohnLBergqvist merged commit 54c20cd into develop Jul 1, 2024
40 of 41 checks passed
@JohnLBergqvist JohnLBergqvist deleted the update-expired-signing-key-for-msi-installer branch July 1, 2024 13:41
@tautschnig tautschnig mentioned this pull request Jul 1, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants