Skip to content

CMake builds: support system-installed CaDiCaL #8159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

tautschnig
Copy link
Collaborator

Just like we support system-installed MiniSat2 we now support CaDiCaL when selecting "system-cadical" as solver.

Fixes: #8113

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Just like we support system-installed MiniSat2 we now support CaDiCaL
when selecting "system-cadical" as solver.

Fixes: diffblue#8113
@tautschnig tautschnig requested a review from a team as a code owner January 15, 2024 11:24
Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fd28cb2) 79.09% compared to head (43365c9) 79.69%.
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8159      +/-   ##
===========================================
+ Coverage    79.09%   79.69%   +0.59%     
===========================================
  Files         1695     1680      -15     
  Lines       196589   195104    -1485     
===========================================
- Hits        155493   155479      -14     
+ Misses       41096    39625    -1471     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@peterschrammel peterschrammel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this concern CMake only?

@tautschnig
Copy link
Collaborator Author

Does this concern CMake only?

In the make-based build system the user has to manually run the cadical-download target, or could choose to skip this any instead set variables appropriately.

@tautschnig tautschnig merged commit 4a5c797 into diffblue:develop Feb 6, 2024
@tautschnig tautschnig deleted the features/system-cadical branch February 6, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build with system CaDiCaL
3 participants