Skip to content

cbmc preprocessing: call set_language_options after checking for null #8149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 30, 2023

Conversation

kroening
Copy link
Member

@kroening kroening commented Dec 24, 2023

This avoids a segfault when there is no appropriate language module.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link

codecov bot commented Dec 24, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ccec4dd) 79.10% compared to head (50050a4) 79.10%.

Files Patch % Lines
src/cbmc/cbmc_parse_options.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8149   +/-   ##
========================================
  Coverage    79.10%   79.10%           
========================================
  Files         1695     1695           
  Lines       196596   196596           
========================================
  Hits        155517   155517           
  Misses       41079    41079           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kroening kroening marked this pull request as ready for review December 25, 2023 12:06
This avoids a segfault when there is no appropriate language module.
@kroening kroening force-pushed the set_language_options branch from b7a58c5 to 50050a4 Compare December 30, 2023 08:29
@kroening kroening enabled auto-merge December 30, 2023 08:30
@kroening kroening merged commit 6494e9e into develop Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants