Variables leaving scope on jumping should always be marked dead #8092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even if new variables would be introduced to the scope, the existing variables which go out of scope still need to be marked as dead and/or have their destructors called. The placeholder for construction is moved to after the destruction, as destructions should be done first.
thomasspriggs
requested review from
kroening,
tautschnig and
peterschrammel
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8092 +/- ##
========================================
Coverage 79.07% 79.07%
========================================
Files 1698 1698
Lines 196463 196463
========================================
Hits 155346 155346
Misses 41117 41117 ☔ View full report in Codecov by Sentry. |
TGWDB
approved these changes
Dec 5, 2023
esteffin
approved these changes
Dec 5, 2023
tautschnig
approved these changes
Dec 5, 2023
|
The CSmith test failure is safe to ignore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that variables leaving scope on jumping are always marked as dead. Even if new variables would be introduced to the scope, the existing variables which go out of scope still need to be marked as dead and/or have their destructors called. This was discovered during investigation for issue #7997 . The issue fixed in this PR should be fixed in order to ensure that variable lifetimes are handled correctly. It has been split from the work to fix the linked issue as it is not required for the example outlined in that issue.