Skip to content

Delete string_constantt::get_value and string_constantt::set_value functions #8003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

NlightNFotis
Copy link
Contributor

Marked DEPRECATED over the value() function.

Depends on #7999

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.28%. Comparing base (8bab263) to head (9299bc8).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8003      +/-   ##
===========================================
+ Coverage    78.23%   78.28%   +0.05%     
===========================================
  Files         1722     1722              
  Lines       188692   188556     -136     
  Branches     18452    18459       +7     
===========================================
- Hits        147615   147612       -3     
+ Misses       41077    40944     -133     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tautschnig tautschnig marked this pull request as ready for review June 12, 2024 15:02
…:set_value`.

Marked `DEPRECATED` over the `value()` calls (they were already working by
dispatching to `value()`, so they were kind of a useless indirection/duplication).
@tautschnig tautschnig force-pushed the delete_get_set_value branch from 63bd19b to 9299bc8 Compare June 12, 2024 15:03
@kroening kroening enabled auto-merge June 12, 2024 17:13
@kroening kroening merged commit 744083a into diffblue:develop Jun 12, 2024
39 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants