Skip to content

CODING_STANDARD.md: fix references to clang-format #7995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2023
Merged

Conversation

kroening
Copy link
Member

@kroening kroening commented Nov 4, 2023

This fixes the description of how to use clang-format in CODING_STANDARD.md.

  • The CI uses clang-format-11 (as opposed to -10) since 557d941.

  • The promise that this is available on Ubuntu 18.04 cannot be met. The earliest version of Ubuntu that has clang-format-11 out of the box is 20.04.

  • There is a reference to COMPILING.md, which does not say anything at all about clang-format.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • n/a Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

This fixes the description of how to use clang-format in CODING_STANDARD.md.

* The CI uses clang-format-11 (as opposed to -10) since
  557d941.

* The promise that this is available on Ubuntu 18.04 cannot be met.  The
  earliest version of Ubuntu that has clang-format-11 out of the box is
  20.04.

* There is a reference to COMPILING.md, which does not say anything at all
  about clang-format.
Copy link

codecov bot commented Nov 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cb62568) 78.80% compared to head (d082399) 77.31%.
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7995      +/-   ##
===========================================
- Coverage    78.80%   77.31%   -1.50%     
===========================================
  Files         1701     1701              
  Lines       196462   196465       +3     
===========================================
- Hits        154819   151890    -2929     
- Misses       41643    44575    +2932     

see 111 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kroening kroening merged commit 9238a38 into develop Nov 5, 2023
@kroening kroening deleted the clang-format branch November 5, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants