Skip to content

C++ front-end: fix type checking of anonymous bit fields #7848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

tautschnig
Copy link
Collaborator

For unsigned : 2; we tried to merge a necessarily empty (not nil!) irept via merge_types. MacOS has such anonymous bit fields in some system headers.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (fa1d719) 78.74% compared to head (be2a41c) 78.74%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7848      +/-   ##
===========================================
- Coverage    78.74%   78.74%   -0.01%     
===========================================
  Files         1699     1699              
  Lines       195105   195105              
===========================================
- Hits        153634   153627       -7     
- Misses       41471    41478       +7     
Files Changed Coverage Δ
src/cpp/parse.cpp 69.39% <100.00%> (+0.30%) ⬆️

... and 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tautschnig tautschnig self-assigned this Aug 15, 2023
For `unsigned x : 2, : 2;` we tried to merge a necessarily empty (not
nil!) irept via `merge_types`. MacOS has such anonymous bit fields in
some system headers.
@kroening kroening merged commit d84744f into diffblue:develop Aug 17, 2023
@tautschnig tautschnig deleted the bugfixes/c++-bitfields branch August 18, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants