-
Notifications
You must be signed in to change notification settings - Fork 274
Add incremental SMT support for struct with and member expressions #7787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
thomasspriggs
merged 12 commits into
diffblue:develop
from
thomasspriggs:tas/smt_struct_with_member
Jul 13, 2023
Merged
Add incremental SMT support for struct with and member expressions #7787
thomasspriggs
merged 12 commits into
diffblue:develop
from
thomasspriggs:tas/smt_struct_with_member
Jul 13, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #7787 +/- ##
===========================================
+ Coverage 78.58% 78.64% +0.06%
===========================================
Files 1693 1697 +4
Lines 193381 193894 +513
===========================================
+ Hits 151962 152491 +529
+ Misses 41419 41403 -16
☔ View full report in Codecov by Sentry. |
To ensure that following tests have "beginning", "middle" and "end" fields and so increase the thoroughness of them.
de167e9
to
dfa8661
Compare
This already reads large parts of the internal state, so the refactor cuts down on parameters passed and enables use of other member functions.
The previous lowering of enums alone prevents this from working as needed for structs.
So that the call for getting the index term can more easily be distinguished from the rest of the expression.
In preparation for array of struct support.
dfa8661
to
458efb5
Compare
458efb5
to
d71b2dc
Compare
04f2fd4
to
2a2982c
Compare
2a2982c
to
c4ccf66
Compare
NlightNFotis
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds incremental SMT support for struct with and member expressions.