Improvement to c_enum_typet interface #7764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esteffin
requested review from
kroening,
tautschnig,
peterschrammel and
remi-delmas-3000
as code owners
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #7764 +/- ##
========================================
Coverage 78.57% 78.57%
========================================
Files 1693 1693
Lines 193306 193309 +3
========================================
+ Hits 151890 151893 +3
Misses 41416 41416
☔ View full report in Codecov by Sentry. |
esteffin
force-pushed
the
esteffin/improve-c-enum-constructor
branch
from
705f150 to
a247ba0
Compare
tautschnig
approved these changes
Jun 14, 2023
esteffin
force-pushed
the
esteffin/improve-c-enum-constructor
branch
from
a247ba0 to
7a5c6c4
Compare
NlightNFotis
approved these changes
Jun 15, 2023
added 2 commits
June 15, 2023 10:42
Interface for c_enum_typet has limited support for management of enum members. This commit adds: - a function for exposing the member vector as a non-const reference, - a constructor that takes the underlying type and a list of members and sets the constructed type accordingly.
esteffin
force-pushed
the
esteffin/improve-c-enum-constructor
branch
from
7a5c6c4 to
2498769
Compare
thomasspriggs
approved these changes
Jun 15, 2023
| @@ -36,7 +36,8 @@ static type_symbolt make_c_enum_type_symbol(std::size_t underlying_size) | |||
| const signedbv_typet underlying_type{underlying_size}; | |||
| c_enum_typet enum_type{underlying_type}; | |||
|
|
|||
| auto &members = enum_type.add(ID_body).get_sub(); | |||
| auto &members = enum_type.members(); | |||
| members.reserve(20); | |||
There was a problem hiding this comment.
⛏️ I might have stored 20 in a constant instead of duplicating the same magic number in 2 places.
⛏️ Also reserve is used for performance reasons. So maybe it is better to omit it in a unit test context in order to aid readability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the
c_enum_typetinterface to avoid having to directly access itssubcomponents to add members.To achieve this it:
members()function returning a non-constreferencestd::vectorof members to populate the enumeration with.The PR also refactor the code where the
c_enum_typetvalues are populated inc_typecheck_typeto use the newmembersfunction.