Skip to content

Changed "requires" as variable names to differentiate from c++20 keyword requires #7751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

jparsert
Copy link

@jparsert jparsert commented Jun 4, 2023

Fixes #7750 by changing some variable and argument names.

@codecov
Copy link

codecov bot commented Jun 4, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (ff55271) 78.55% compared to head (fadd0be) 78.55%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7751   +/-   ##
========================================
  Coverage    78.55%   78.55%           
========================================
  Files         1691     1691           
  Lines       193136   193171   +35     
========================================
+ Hits        151721   151755   +34     
- Misses       41415    41416    +1     
Impacted Files Coverage Δ
src/goto-instrument/contracts/memory_predicates.h 100.00% <ø> (ø)
.../contracts/dynamic-frames/dfcc_wrapper_program.cpp 95.96% <100.00%> (+0.04%) ⬆️
...rc/goto-instrument/contracts/memory_predicates.cpp 84.40% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@tautschnig tautschnig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still needs a clang-format fix.

@jparsert jparsert force-pushed the fix_cpp20_requires_keyword branch from f9c103e to fadd0be Compare June 7, 2023 10:47
@jparsert
Copy link
Author

jparsert commented Jun 7, 2023

@tautschnig Thanks, I added the syntactic changes suggested by clang-format.

@kroening kroening merged commit 275510d into diffblue:develop Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Requires keyword is still present in code base (with regards to C++20).
5 participants