Skip to content

Piped process: fix off-by-one error #7738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2023

Conversation

tautschnig
Copy link
Collaborator

The NULL terminator previously was an out-of-bounds write. This fixes the test failure seen in
https://github.com/diffblue/cbmc/actions/runs/5112785459/jobs/9191230589?pr=7395, which was locally reproducible. Out-of-bounds write found by valgrind via

regression/cbmc/dynamic_sizeof1$ valgrind \
  ../../../build-coverage/bin/cbmc main.c \
  --incremental-smt2-solver 'z3 --smt2 -in'
  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

The NULL terminator previously was an out-of-bounds write. This fixes
the test failure seen in
https://github.com/diffblue/cbmc/actions/runs/5112785459/jobs/9191230589?pr=7395,
which was locally reproducible. Out-of-bounds write found by `valgrind`
via
```
regression/cbmc/dynamic_sizeof1$ valgrind \
  ../../../build-coverage/bin/cbmc main.c \
  --incremental-smt2-solver 'z3 --smt2 -in'
```
@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02 ⚠️

Comparison is base (d5e13f1) 78.54% compared to head (c47e940) 78.53%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7738      +/-   ##
===========================================
- Coverage    78.54%   78.53%   -0.02%     
===========================================
  Files         1688     1688              
  Lines       193001   193001              
===========================================
- Hits        151599   151565      -34     
- Misses       41402    41436      +34     
Impacted Files Coverage Δ
src/util/piped_process.cpp 81.92% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kroening kroening merged commit 26b8027 into diffblue:develop May 30, 2023
@tautschnig tautschnig deleted the bugfixes/piped-process branch May 30, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants