Skip to content

Remove typecheckt interface from linkingt #7728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2023

Conversation

tautschnig
Copy link
Collaborator

There is no particular benefit in this inheritance. Also prepare for maintaining state across multiple calls to the linker by making the source symbol table an argument specific to each linking call.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

There is no particular benefit in this inheritance. Also prepare for
maintaining state across multiple calls to the linker by making the
source symbol table an argument specific to each linking call.
@tautschnig tautschnig force-pushed the cleanup/linking-interface branch from 191d6b0 to 7df3543 Compare May 23, 2023 15:05
@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.03 ⚠️

Comparison is base (cfcfcf6) 78.57% compared to head (7df3543) 78.55%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7728      +/-   ##
===========================================
- Coverage    78.57%   78.55%   -0.03%     
===========================================
  Files         1685     1685              
  Lines       192962   192966       +4     
===========================================
- Hits        151624   151579      -45     
- Misses       41338    41387      +49     
Impacted Files Coverage Δ
src/goto-programs/link_goto_model.cpp 87.50% <100.00%> (ø)
src/linking/linking.cpp 62.13% <100.00%> (-7.16%) ⬇️
src/linking/linking_class.h 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kroening kroening merged commit be6bfca into diffblue:develop May 23, 2023
@tautschnig tautschnig deleted the cleanup/linking-interface branch May 23, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants