Skip to content

Fix includes for BDD_GUARDS #7727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2023

Conversation

tautschnig
Copy link
Collaborator

guard_bddt needs bdd_exprt, but failed to include the necessary header.

Fixes: #7726

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig force-pushed the bugfixes/7726-guard-manager branch from dafd0d9 to 42b18a2 Compare May 23, 2023 09:26
`guard_bddt` needs `bdd_exprt`, but failed to include the necessary
header.

Fixes: diffblue#7726
@tautschnig tautschnig force-pushed the bugfixes/7726-guard-manager branch from 42b18a2 to 1315b61 Compare May 23, 2023 09:28
@tautschnig tautschnig requested a review from kroening as a code owner May 23, 2023 09:28
@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (cfcfcf6) 78.57% compared to head (1315b61) 78.57%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7727   +/-   ##
========================================
  Coverage    78.57%   78.57%           
========================================
  Files         1685     1685           
  Lines       192962   192979   +17     
========================================
+ Hits        151624   151639   +15     
- Misses       41338    41340    +2     
Impacted Files Coverage Δ
.../goto-instrument/goto_instrument_parse_options.cpp 72.14% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tautschnig tautschnig merged commit fc35bed into diffblue:develop May 23, 2023
@tautschnig tautschnig deleted the bugfixes/7726-guard-manager branch May 23, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compiling with experimental BDD guards fails
5 participants