Skip to content

Code contracts: cleanup get_fresh_aux_symbol wrappers #7721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tautschnig
Copy link
Collaborator

@tautschnig tautschnig commented May 18, 2023

  1. Consistently either use the wrappers or get_fresh_aux_symbol
    directly.
  2. Remove wrappers that did not yield significant simplification.
  3. Make remaining wrappers do all work that was previously done by each
    caller.

Depends on #7683 (which is the first commit).

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig self-assigned this May 18, 2023
@tautschnig tautschnig force-pushed the cleanup/contracts-symbol-create branch from 3ff0b4f to 68a393f Compare May 22, 2023 08:54
@tautschnig tautschnig marked this pull request as ready for review May 22, 2023 08:54
1. Consistently either use the wrappers or get_fresh_aux_symbol
directly.
2. Remove wrappers that did not yield significant simplification.
3. Make remaining wrappers do all work that was previously done by each
caller.
@tautschnig tautschnig force-pushed the cleanup/contracts-symbol-create branch from 68a393f to 9ca2e66 Compare May 22, 2023 10:53
@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

❗ No coverage uploaded for pull request base (develop@ce4c504). Click here to learn what that means.
Patch coverage: 98.14% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #7721   +/-   ##
==========================================
  Coverage           ?   78.56%           
==========================================
  Files              ?     1685           
  Lines              ?   192848           
  Branches           ?        0           
==========================================
  Hits               ?   151510           
  Misses             ?    41338           
  Partials           ?        0           
Impacted Files Coverage Δ
...nt/contracts/dynamic-frames/dfcc_instrument_loop.h 66.66% <ø> (ø)
...ent/contracts/dynamic-frames/dfcc_spec_functions.h 100.00% <ø> (ø)
...oto-instrument/contracts/instrument_spec_assigns.h 94.73% <ø> (ø)
src/goto-instrument/contracts/utils.h 100.00% <ø> (ø)
...ument/contracts/dynamic-frames/dfcc_instrument.cpp 83.79% <86.95%> (ø)
src/goto-instrument/contracts/contracts.cpp 94.83% <100.00%> (ø)
...trument/contracts/dynamic-frames/dfcc_cfg_info.cpp 79.00% <100.00%> (ø)
.../contracts/dynamic-frames/dfcc_instrument_loop.cpp 99.61% <100.00%> (ø)
...t/contracts/dynamic-frames/dfcc_spec_functions.cpp 92.12% <100.00%> (ø)
...instrument/contracts/dynamic-frames/dfcc_utils.cpp 98.64% <100.00%> (ø)
... and 4 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tautschnig tautschnig merged commit cfcfcf6 into diffblue:develop May 22, 2023
@tautschnig tautschnig deleted the cleanup/contracts-symbol-create branch May 22, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code Contracts Function and loop contracts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants