Skip to content

Limit string length to avoid spurious regression test failure #7715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tautschnig
Copy link
Collaborator

@tautschnig tautschnig commented May 16, 2023

As seen in
https://github.com/diffblue/cbmc/actions/runs/4979949266/jobs/8933402303?pr=7413 we may end up with a counterexample too large to store on GitHub's runner. Limit the string length as the length is immaterial to the test.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

As seen in
https://github.com/diffblue/cbmc/actions/runs/4979949266/jobs/8933402303?pr=7413
we may end up with a counterexample too large store on GitHub's runner.
Limit the string length as the length is immaterial to the test.
@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (0325f8e) 78.55% compared to head (367340b) 78.55%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7715   +/-   ##
========================================
  Coverage    78.55%   78.55%           
========================================
  Files         1686     1686           
  Lines       192930   192930           
========================================
  Hits        151562   151562           
  Misses       41368    41368           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tautschnig tautschnig merged commit 339505b into diffblue:develop May 18, 2023
@tautschnig tautschnig deleted the bugfixes/limit-string-length branch May 18, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants