Skip to content

Cleanup the API of dfcc_loop_nesting_grapht #7693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 12, 2023

Conversation

tautschnig
Copy link
Collaborator

Please review commit-by-commit.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.16 🎉

Comparison is base (535e6b2) 78.38% compared to head (fe428ad) 78.55%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7693      +/-   ##
===========================================
+ Coverage    78.38%   78.55%   +0.16%     
===========================================
  Files         1686     1686              
  Lines       192915   192915              
===========================================
+ Hits        151215   151539     +324     
+ Misses       41700    41376     -324     
Impacted Files Coverage Δ
src/analyses/loop_analysis.h 100.00% <ø> (ø)
...nstrument/contracts/dynamic-frames/dfcc_cfg_info.h 100.00% <ø> (ø)
...trument/contracts/dynamic-frames/dfcc_cfg_info.cpp 78.63% <100.00%> (ø)
...ntracts/dynamic-frames/dfcc_loop_nesting_graph.cpp 96.66% <100.00%> (ø)

... and 21 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tautschnig tautschnig force-pushed the cleanup/nesting-graph-loopt branch from 4b5e911 to 670d9fd Compare April 27, 2023 12:42
@feliperodri feliperodri added aws Bugs or features of importance to AWS CBMC users Code Contracts Function and loop contracts labels May 1, 2023
@tautschnig tautschnig marked this pull request as draft May 4, 2023 13:49
Direct use of this header file made apparent that it didn't include what
actually is required to use it: the declaration of goto_modelt.
Directly refer to the classes rather than going through a series of
(member) typedefs and one header that is rather unrelated.
@tautschnig tautschnig force-pushed the cleanup/nesting-graph-loopt branch from 670d9fd to fe428ad Compare May 12, 2023 14:09
@tautschnig tautschnig marked this pull request as ready for review May 12, 2023 14:09
@peterschrammel peterschrammel removed their assignment May 12, 2023
@tautschnig tautschnig merged commit c64e9f7 into diffblue:develop May 12, 2023
@tautschnig tautschnig deleted the cleanup/nesting-graph-loopt branch May 12, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws Bugs or features of importance to AWS CBMC users cleanup Code Contracts Function and loop contracts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants