Skip to content

Remove dfcc_utilst::inhibit_unused_functions #7684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

tautschnig
Copy link
Collaborator

This has neither been implemented nor used so far. If a future use is necessary, then this commit should just be reverted.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.04 ⚠️

Comparison is base (31dfa3e) 78.42% compared to head (5b99a6f) 78.39%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7684      +/-   ##
===========================================
- Coverage    78.42%   78.39%   -0.04%     
===========================================
  Files         1674     1674              
  Lines       191948   191946       -2     
===========================================
- Hits        150543   150475      -68     
- Misses       41405    41471      +66     
Impacted Files Coverage Δ
.../goto-instrument/contracts/dynamic-frames/dfcc.cpp 98.02% <ø> (ø)
...instrument/contracts/dynamic-frames/dfcc_utils.cpp 88.27% <ø> (+0.64%) ⬆️
...o-instrument/contracts/dynamic-frames/dfcc_utils.h 0.00% <ø> (ø)

... and 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

This has neither been implemented nor used so far. If a future use is
necessary, then this commit could be reverted, or the solution be
implemented in place (comment has now been moved to the only site that
intended to use it).
@tautschnig tautschnig force-pushed the cleanup/remove-inhibit_unused_functions branch from 65c870b to 5b99a6f Compare April 27, 2023 10:17
@tautschnig tautschnig merged commit 4ccdcd5 into diffblue:develop Apr 27, 2023
@tautschnig tautschnig deleted the cleanup/remove-inhibit_unused_functions branch April 27, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants