Skip to content

Remove Ubuntu-18.04 jobs since github deprecated them #7657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

TGWDB
Copy link
Contributor

@TGWDB TGWDB commented Apr 11, 2023

This is in response to this announcement.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@TGWDB TGWDB requested a review from a team as a code owner April 11, 2023 14:38
Copy link
Contributor

@thomasspriggs thomasspriggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, we should remove the references to Ubuntu 18 from the work flows documentation -

* an `ubuntu-18.04` package

and from the release page text -
I think the release text also needs Ubuntu 22.04 adding to it, as I think this was missed when we added the 22.04 package to the releases

@TGWDB TGWDB force-pushed the 20230411-remove-ubuntu-1804 branch from 8a1ecda to 3ea2891 Compare April 11, 2023 15:22
@TGWDB
Copy link
Contributor Author

TGWDB commented Apr 11, 2023

Looks good so far, we should remove the references to Ubuntu 18 from the work flows documentation -

* an `ubuntu-18.04` package

and from the release page text -

I think the release text also needs Ubuntu 22.04 adding to it, as I think this was missed when we added the 22.04 package to the releases

Fixed both, thanks.

@@ -54,13 +54,8 @@ jobs:
brew upgrade cbmc
```

## Ubuntu
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change overshot slightly - we shouldn't delete the headers or the instruction text, just the dpkg instructions for Ubuntu 18.

@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (888a08a) 78.51% compared to head (37b4bd7) 78.51%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7657   +/-   ##
========================================
  Coverage    78.51%   78.51%           
========================================
  Files         1674     1674           
  Lines       191935   191935           
========================================
  Hits        150704   150704           
  Misses       41231    41231           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TGWDB TGWDB force-pushed the 20230411-remove-ubuntu-1804 branch from 3ea2891 to fae60fb Compare April 11, 2023 15:28
@TGWDB TGWDB force-pushed the 20230411-remove-ubuntu-1804 branch from fae60fb to 37b4bd7 Compare April 11, 2023 15:29
@TGWDB TGWDB merged commit 00f1d72 into develop Apr 12, 2023
@NlightNFotis NlightNFotis deleted the 20230411-remove-ubuntu-1804 branch April 12, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants