-
Notifications
You must be signed in to change notification settings - Fork 274
Remove Ubuntu-18.04 jobs since github deprecated them #7657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far, we should remove the references to Ubuntu 18 from the work flows documentation -
cbmc/.github/workflows/README.md
Line 41 in 888a08a
* an `ubuntu-18.04` package |
and from the release page text -
# Ubuntu 18: |
I think the release text also needs Ubuntu 22.04 adding to it, as I think this was missed when we added the 22.04 package to the releases
8a1ecda
to
3ea2891
Compare
Fixed both, thanks. |
@@ -54,13 +54,8 @@ jobs: | |||
brew upgrade cbmc | |||
``` | |||
|
|||
## Ubuntu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change overshot slightly - we shouldn't delete the headers or the instruction text, just the dpkg
instructions for Ubuntu 18.
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #7657 +/- ##
========================================
Coverage 78.51% 78.51%
========================================
Files 1674 1674
Lines 191935 191935
========================================
Hits 150704 150704
Misses 41231 41231 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
3ea2891
to
fae60fb
Compare
fae60fb
to
37b4bd7
Compare
This is in response to this announcement.