Simplify inequality over pointers #7650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
force-pushed
the
features/less-than-pointer-simp
branch
2 times, most recently
from
3c2bd1f to
c697839
Compare
tautschnig
force-pushed
the
features/less-than-pointer-simp
branch
from
c697839 to
3cd771e
Compare
When using pointers as iterators we may see less-than (or less-or-equal) comparison of pointers with some offsets. When the base pointers point to the same root object we can safely simplify this. Also avoid undefined behaviour (pointer below object bounds) in regression test.
tautschnig
force-pushed
the
features/less-than-pointer-simp
branch
from
3cd771e to
25a050a
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #7650 +/- ##
===========================================
- Coverage 78.52% 78.41% -0.11%
===========================================
Files 1674 1674
Lines 191971 191970 -1
===========================================
- Hits 150738 150534 -204
- Misses 41233 41436 +203
... and 12 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
peterschrammel
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using pointers as iterators we may see less-than (or less-or-equal) comparison of pointers with some offsets. When the base pointers point to the same root object we can safely simplify this.