Skip to content

Enable constant propagation in less-than encoding #7618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

tautschnig
Copy link
Collaborator

When comparing two bitvectors that are (in parts) constant then the result should be a constant.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig self-assigned this Mar 24, 2023
Copy link
Collaborator

@martin-cs martin-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes; good catch!

When comparing two bitvectors that are (in parts) constant then the
result should be a constant.
@tautschnig tautschnig marked this pull request as ready for review April 18, 2023 15:17
@tautschnig tautschnig force-pushed the features/less-than-prop branch from 6a204e1 to e265a42 Compare April 18, 2023 15:21
@tautschnig tautschnig merged commit b1b39e8 into diffblue:develop Apr 18, 2023
@tautschnig tautschnig deleted the features/less-than-prop branch April 18, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants