check for java bytecode index in the existing coverage #761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgudemann
suggested changes
Apr 5, 2017
src/goto-instrument/cover.cpp
Outdated
| break; | ||
| if(!source_location.get_java_bytecode_index().compare( | ||
| it->get_java_bytecode_index()) && | ||
| !source_location.get_file().compare(it->get_file()) && |
There was a problem hiding this comment.
get_java_bytecode_index should only be compared when using a Java analysis
There was a problem hiding this comment.
Now we check whether get_java_bytecode_index is empty.
lucasccordeiro
force-pushed
the
test-gen-support-fix-issue-15
branch
2 times, most recently
from
77a5646 to
00cb2b0
Compare
mgudemann
suggested changes
Apr 6, 2017
src/goto-instrument/cover.cpp
Outdated
| if(!given_location.get_file().compare(known_location->get_file()) && | ||
| !given_location.get_function().compare(known_location->get_function()) && | ||
| !given_location.get_line().compare(known_location->get_line())) | ||
| { |
There was a problem hiding this comment.
as compare returns an int, could you test on 0 here?
src/goto-instrument/cover.cpp
Outdated
| if(source_location.get_java_bytecode_index().empty()) | ||
| break; | ||
| else if(!source_location.get_java_bytecode_index().compare( | ||
| it->get_java_bytecode_index())) |
|
there is also compile failures on travis, please fix those, too |
check whether the java bytecode index matches for the existing coverage goals
lucasccordeiro
force-pushed
the
test-gen-support-fix-issue-15
branch
from
aed785c to
2d7b34a
Compare
|
Due to several merge conflicts, I have created another PR to handle this issue: #772 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check whether the java bytecode index matches for the existing coverage goals/