Skip to content

Name type to regain macOS 10.14.6 compatibility #7580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

tautschnig
Copy link
Collaborator

Avoid (spurious) ambiguity by explicitly naming the type to be constructed. This seems to be required by the compiler shipped with macOS 10.14.6.

Fixes: #7464

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Avoid (spurious) ambiguity by explicitly naming the type to be
constructed. This seems to be required by the compiler shipped with
macOS 10.14.6.

Fixes: diffblue#7464
@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change

Comparison is base (014188e) 78.50% compared to head (3174549) 78.50%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7580   +/-   ##
========================================
  Coverage    78.50%   78.50%           
========================================
  Files         1670     1670           
  Lines       191767   191768    +1     
========================================
+ Hits        150548   150549    +1     
  Misses       41219    41219           
Impacted Files Coverage Δ
...lvers/smt2_incremental/smt_response_validation.cpp 95.38% <100.00%> (+0.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tautschnig tautschnig merged commit f6898d4 into diffblue:develop Mar 7, 2023
@tautschnig tautschnig deleted the cleanup/7464-type-lookup branch March 7, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when compiling develop on MacOS
5 participants