Honour --sat-solver with refinement #7544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move all SAT solver construction to a procedure of its own. This is in preparation of also constructing the solver for refinement, which does not yet honour the new `--sat-solver` option.
With the preceding commit we now apply RAII, making default-constructing unnecessary.
peterschrammel
approved these changes
Feb 16, 2023
Refinement should not unconditionally use the default solver despite the user specifying `--sat-solver <solver>` on the command line.
tautschnig
force-pushed
the
features/refinement-sat-solver
branch
from
acfd5cd to
f1be42c
Compare
TGWDB
approved these changes
Feb 16, 2023
Codecov ReportBase: 78.21% // Head: 78.48% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #7544 +/- ##
===========================================
+ Coverage 78.21% 78.48% +0.27%
===========================================
Files 1667 1667
Lines 191473 191463 -10
===========================================
+ Hits 149758 150277 +519
+ Misses 41715 41186 -529
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All work done in this PR is to support the last commit here; please review commit-by-commit.