-
Notifications
You must be signed in to change notification settings - Fork 274
Fix building with gcc 12 #7542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix building with gcc 12 #7542
Conversation
thomasspriggs
commented
Feb 15, 2023
- Each commit message has a non-empty body, explaining why the change was made.
- Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
- The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
- Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
- My commit message includes data points confirming performance improvements (if claimed).
- My PR is restricted to a single feature or bugfix.
- White-space or formatting changes outside the feature-related changed lines are in commits of their own.
f202727
to
1e926b6
Compare
Pushing the warning exception is not a straight forward solution in this case. This is because gcc-12 still generates the warning on read of `contract` instead of on initialisation of `contract`.
1e926b6
to
5463349
Compare
Codecov ReportBase: 78.31% // Head: 78.48% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #7542 +/- ##
===========================================
+ Coverage 78.31% 78.48% +0.17%
===========================================
Files 1667 1667
Lines 191475 191476 +1
===========================================
+ Hits 149958 150289 +331
+ Misses 41517 41187 -330
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Looks like a good alternative to #7540 , I notice the new job has significantly higher runtime than the straight gcc one. This partly due to me wanting to see the typical build time in the CI job comment as in the other jobs (obviously not really known until tested). |
I'd guess the longer run time will be due to the build cache being cold. I'll restart the jobs to get a better idea of the variation. |
For my own reference the total run time for the initial run was 46m 26s, with 23m 44s of that being the build time. |
5463349
to
cdf3d4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming the cache/timing comment can be resolved.
Note to self - job time is 45m 52s, 23m 28s building after the cache fix, with cold cache. |
Note to self - Job time is 26m 43s, of which 38s is building, when cache is warm. |
cdf3d4e
to
bfb968b
Compare