Skip to content

Remove unused function_depth variable #7529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

tautschnig
Copy link
Collaborator

Compact goto traces never print depth information (unlike full trace output): function_depth was initialised and being written to, but never read. This was always the case (the code was added in b62ffe9), it's not a matter of printing having been removed.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Compact goto traces never print depth information (unlike full trace
output): `function_depth` was initialised and being written to, but
never read. This was always the case (the code was added in
b62ffe9), it's not a matter of printing having been removed.
@tautschnig tautschnig force-pushed the cleanup/function_depth branch from 78908e2 to 58f553f Compare February 9, 2023 14:56
@peterschrammel peterschrammel removed their assignment Feb 10, 2023
@tautschnig tautschnig merged commit fbd2b88 into diffblue:develop Feb 10, 2023
@tautschnig tautschnig deleted the cleanup/function_depth branch February 10, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants