Skip to content

Fix ccache restore key for check-macos-12-cmake-clang #7522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

tautschnig
Copy link
Collaborator

We must not pick up a cache generated by the non-Glucose job, which has the same prefix. Doing so would result in a cache that mixes different configurations, and ccache may end up pruning the wrong ones.

While at it, also insert hyphens to make cache entry names easier to read.

Performance note: in #7428, check-macos-12-cmake-clang just spent 28 minutes building with 0 cache hits, despite 1115 entries in the cache. Other jobs completed the build stage within seconds. I have manually removed the possibly offending caches from https://github.com/diffblue/cbmc/actions/caches, but we may need to do another cleanup once this PR is merged.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

We must not pick up a cache generated by the non-Glucose job, which has
the same prefix. Doing so would result in a cache that mixes different
configurations, and ccache may end up pruning the wrong ones.

While at it, also insert hyphens to make cache entry names easier to
read.
@codecov
Copy link

codecov bot commented Feb 4, 2023

Codecov Report

Base: 78.50% // Head: 78.49% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (358386e) compared to base (3f578e1).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7522      +/-   ##
===========================================
- Coverage    78.50%   78.49%   -0.02%     
===========================================
  Files         1663     1663              
  Lines       191297   191331      +34     
===========================================
+ Hits        150174   150180       +6     
- Misses       41123    41151      +28     
Impacted Files Coverage Δ
src/solvers/smt2/smt2_dec.cpp 70.16% <0.00%> (-3.12%) ⬇️
src/goto-checker/solver_factory.cpp 81.23% <0.00%> (-0.79%) ⬇️
src/solvers/smt2/smt2_conv.cpp 67.26% <0.00%> (-0.38%) ⬇️
src/solvers/smt2/smt2_conv.h 87.50% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@NlightNFotis NlightNFotis merged commit 7f96b25 into diffblue:develop Feb 6, 2023
@tautschnig tautschnig deleted the bugfixes/cache-keys branch February 6, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants