SYNTHESIZER: Synthesize loop assigns before loop invariants. #7458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qinheping
added
aws
qinheping
requested review from
tautschnig,
feliperodri and
remi-delmas-3000
as code owners
Codecov ReportBase: 78.48% // Head: 78.48% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #7458 +/- ##
===========================================
- Coverage 78.48% 78.48% -0.01%
===========================================
Files 1663 1663
Lines 191136 191189 +53
===========================================
+ Hits 150017 150046 +29
- Misses 41119 41143 +24
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
tautschnig
reviewed
Dec 28, 2022
qinheping
force-pushed
the
goto-synthesizer
branch
from
6bd1bd5 to
019952e
Compare
tautschnig
reviewed
Jan 9, 2023
Comment on lines
73
to
87
| while(lhs_pointer->type().id() != ID_pointer) | ||
| { | ||
| INVARIANT( | ||
| lhs_pointer->operands().size() > 0, | ||
| " No pointer found in lhs of NULL-pointer checks."); | ||
| lhs_pointer = &lhs_pointer->operands()[0]; | ||
| } | ||
|
|
||
| while(rhs_pointer->type().id() != ID_pointer) | ||
| { | ||
| INVARIANT( | ||
| rhs_pointer->operands().size() > 0, | ||
| " No pointer found in lhs of NULL-pointer checks."); | ||
| rhs_pointer = &rhs_pointer->operands()[0]; | ||
| } |
There was a problem hiding this comment.
Would a non-pointer-type operand really be acceptable here?
There was a problem hiding this comment.
It is equal_exprt(pointer_object(p1), pointer_object(p2)); where p1 is a null pointer and p2 is a pointer-type operand. I will make it more explicitly.
qinheping
force-pushed
the
goto-synthesizer
branch
2 times, most recently
from
ae7d464 to
dbbfd16
Compare
tautschnig
approved these changes
Jan 11, 2023
Loop invariants synthesis is dependent on loop-assigns clauses. So we don't target non assignable-violations until all assignable-violations are fixed.
qinheping
force-pushed
the
goto-synthesizer
branch
from
dbbfd16 to
ff62607
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loop invariants synthesis is dependent on loop-assigns clauses. So we target non assignable-violations until all assignable-violations are fixed.