Skip to content

Linking library functions: support constructor functions #7453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 23, 2022

Conversation

tautschnig
Copy link
Collaborator

With 7f1cc0f we may remove __CPROVER_initialize from the goto model, which in turn made us fail to consider constructors called from it among the set of called functions (as well as any functions (transitively) called from these).

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

With 7f1cc0f we may remove `__CPROVER_initialize` from the goto
model, which in turn made us fail to consider constructors called from
it among the set of called functions (as well as any functions
(transitively) called from these).
@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Base: 78.47% // Head: 78.47% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (8d3017f) compared to base (78fb718).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7453      +/-   ##
===========================================
- Coverage    78.47%   78.47%   -0.01%     
===========================================
  Files         1662     1662              
  Lines       191045   191044       -1     
===========================================
- Hits        149931   149929       -2     
- Misses       41114    41115       +1     
Impacted Files Coverage Δ
src/goto-programs/link_to_library.cpp 100.00% <100.00%> (ø)
src/goto-programs/goto_inline.cpp 95.83% <0.00%> (-0.84%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tautschnig tautschnig merged commit fbb702f into diffblue:develop Dec 23, 2022
@tautschnig tautschnig deleted the bugfixes/library-fixedpoint branch December 23, 2022 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws-high bugfix Kani Bugs or features of importance to Kani Rust Verifier
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants