Skip to content

SYNTHESIZER: Add dump-loop-contracts into loop-contracts synthesizer #7451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 23, 2022

Conversation

qinheping
Copy link
Collaborator

@qinheping qinheping commented Dec 22, 2022

Running the loop-contracts synthesizer with the flag dump-loop-contracts will output the synthesized contracts as a JSON file, which can be used to annotate back to the source code with Crangler.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@qinheping qinheping added aws Bugs or features of importance to AWS CBMC users aws-high Code Contracts Function and loop contracts Synthesis Invariant synthesis labels Dec 22, 2022
@qinheping qinheping self-assigned this Dec 22, 2022
Copy link
Collaborator

@jimgrundy jimgrundy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with the changes to the synthesizer, but the changes to c_wranger and the expression type not so much. They do look like improvements/fixes, but they should be factored into their own PRs so they and their consequences can be evaluated without holding up the synthesizer change.

Do please make those other PRs though.

@tautschnig
Copy link
Collaborator

With all other PRs now merged: can you use expr2c with a custom configuration that sets up true and false as you initially did in the default configuration? I believe this will (after a rebase) make all tests pass.

@qinheping qinheping force-pushed the goto-synthesizer branch 2 times, most recently from 5f76815 to 727730f Compare December 23, 2022 15:17
@codecov
Copy link

codecov bot commented Dec 23, 2022

Codecov Report

Base: 78.47% // Head: 78.48% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (531e768) compared to base (954df79).
Patch coverage: 91.13% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7451   +/-   ##
========================================
  Coverage    78.47%   78.48%           
========================================
  Files         1662     1663    +1     
  Lines       191045   191112   +67     
========================================
+ Hits        149931   149992   +61     
- Misses       41114    41120    +6     
Impacted Files Coverage Δ
.../goto-synthesizer/goto_synthesizer_parse_options.h 100.00% <ø> (ø)
...oto-synthesizer/goto_synthesizer_parse_options.cpp 66.66% <73.07%> (-1.34%) ⬇️
src/goto-synthesizer/dump_loop_contracts.cpp 100.00% <100.00%> (ø)
...hesizer/enumerative_loop_contracts_synthesizer.cpp 92.43% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Running the loop-contracts synthesizer with the flag `dump-loop-contracts` will output the synthesized contracts as a JSON file, which can be used to annotate back to the source code with Crangler.
@qinheping qinheping reopened this Dec 23, 2022
@tautschnig tautschnig merged commit 1d6f1eb into diffblue:develop Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws Bugs or features of importance to AWS CBMC users aws-high Code Contracts Function and loop contracts Synthesis Invariant synthesis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants