-
Notifications
You must be signed in to change notification settings - Fork 274
SYNTHESIZER: Add dump-loop-contracts into loop-contracts synthesizer #7451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with the changes to the synthesizer, but the changes to c_wranger and the expression type not so much. They do look like improvements/fixes, but they should be factored into their own PRs so they and their consequences can be evaluated without holding up the synthesizer change.
Do please make those other PRs though.
870ca48
to
52e0328
Compare
With all other PRs now merged: can you use expr2c with a custom configuration that sets up true and false as you initially did in the default configuration? I believe this will (after a rebase) make all tests pass. |
5f76815
to
727730f
Compare
Codecov ReportBase: 78.47% // Head: 78.48% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #7451 +/- ##
========================================
Coverage 78.47% 78.48%
========================================
Files 1662 1663 +1
Lines 191045 191112 +67
========================================
+ Hits 149931 149992 +61
- Misses 41114 41120 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
727730f
to
d8b1c77
Compare
Running the loop-contracts synthesizer with the flag `dump-loop-contracts` will output the synthesized contracts as a JSON file, which can be used to annotate back to the source code with Crangler.
Running the loop-contracts synthesizer with the flag
dump-loop-contracts
will output the synthesized contracts as a JSON file, which can be used to annotate back to the source code with Crangler.