Skip to content

SYNTHESIZER: Migrate loop-contracts synthesizer from goto-instrument into goto-synthesizer #7429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2022

Conversation

qinheping
Copy link
Collaborator

@qinheping qinheping commented Dec 12, 2022

This PR copies the synthesizer interface and expression enumerator from goto-instrument into goto-synthesizer, and removes them from `goto-instrument.

@qinheping qinheping added aws Bugs or features of importance to AWS CBMC users aws-high Code Contracts Function and loop contracts Synthesis Invariant synthesis labels Dec 12, 2022
@qinheping qinheping self-assigned this Dec 12, 2022
@qinheping qinheping changed the title Migrate loop-contracts synthesizer from goto-instrument into goto-synthesizer SYNTHESIZER: Migrate loop-contracts synthesizer from goto-instrument into goto-synthesizer Dec 12, 2022
@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Base: 78.39% // Head: 78.38% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (2a745f8) compared to base (b03d870).
Patch coverage: 85.71% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7429      +/-   ##
===========================================
- Coverage    78.39%   78.38%   -0.02%     
===========================================
  Files         1655     1659       +4     
  Lines       190281   190372      +91     
===========================================
+ Hits        149172   149217      +45     
- Misses       41109    41155      +46     
Impacted Files Coverage Δ
.../goto-instrument/goto_instrument_parse_options.cpp 71.31% <ø> (-0.17%) ⬇️
...rc/goto-instrument/goto_instrument_parse_options.h 100.00% <ø> (ø)
src/goto-synthesizer/expr_enumerator.cpp 75.52% <ø> (ø)
src/goto-synthesizer/expr_enumerator.h 94.59% <ø> (ø)
src/goto-synthesizer/synthesizer_utils.cpp 92.85% <ø> (ø)
...to-synthesizer/expr_enumerator/expr_enumerator.cpp 100.00% <ø> (ø)
...hesizer/enumerative_loop_contracts_synthesizer.cpp 87.50% <66.66%> (ø)
...oto-synthesizer/goto_synthesizer_parse_options.cpp 67.34% <85.00%> (ø)
...nthesizer/enumerative_loop_contracts_synthesizer.h 100.00% <100.00%> (ø)
...goto-synthesizer/loop_contracts_synthesizer_base.h 100.00% <100.00%> (ø)
... and 21 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@qinheping qinheping force-pushed the goto-synthesizer-migration branch 4 times, most recently from ced071d to 4e4f1f4 Compare December 12, 2022 22:28
Copy link
Collaborator

@tautschnig tautschnig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the man pages are also to be updated, and the same is true of the CODEOWNERS file.

@qinheping qinheping force-pushed the goto-synthesizer-migration branch from 4e4f1f4 to 2a745f8 Compare December 13, 2022 04:38
@qinheping qinheping merged commit 6f40463 into diffblue:develop Dec 13, 2022
@qinheping qinheping deleted the goto-synthesizer-migration branch December 19, 2022 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws Bugs or features of importance to AWS CBMC users aws-high Code Contracts Function and loop contracts Synthesis Invariant synthesis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants