-
Notifications
You must be signed in to change notification settings - Fork 273
goto-synthesizer: Separate front-end for loop-contracts synthesizer #7415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportBase: 78.41% // Head: 78.39% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #7415 +/- ##
===========================================
- Coverage 78.41% 78.39% -0.03%
===========================================
Files 1655 1655
Lines 190264 190281 +17
===========================================
- Hits 149201 149172 -29
- Misses 41063 41109 +46
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
f64c5a5
to
8cdb2b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please also amend CODEOWNERS
to include a special rule for this new directory? (I think the rule should be the same as the existing one for the synthesizer.)
@kroening @peterschrammel Would welcome your thoughts here. @qinheping has implemented what I suggested in his other PR, and obviously I'm happy with that :-) Please speak up if you'd prefer not to add a separate binary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok with some minor fixes. Also happy to see a modular approach.
I think CODEOWNERS should be updated to reflect who should review PS here in future.
8cdb2b7
to
bfadb8b
Compare
@NlightNFotis The CI failure is caused by api codes as shown below. Could you please fix it?
|
bfadb8b
to
d89f513
Compare
This issue in |
This introduces a new binary to handle all steps related to loop-contracts synthesis, which previously was part of goto-instrument. The main reason we want a separate front-end is to let one front-end tool to focus on one specific task. Also, there is no termination guarantee for the synthesizer which is not aligned with other functionality of goto-instrument.
No functionality is included in this PR yet. I will migrate the synthesizer into goto-synthesizer once this PR is merged.