Better diagnostics on with_exprt and ifexprt type mismatch

[peterschrammel]

Makes it easier to understand which types are not matching (e.g. ifexprt vs true_case vs false_case).

• Each commit message has a non-empty body, explaining why the change was made.
• [n/a] Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
• [n/a] The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
• [n/a] Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
• [n/a] My commit message includes data points confirming performance improvements (if claimed).
• My PR is restricted to a single feature or bugfix.
• [n/a] White-space or formatting changes outside the feature-related changed lines are in commits of their own.

[codecov]

Codecov Report

Base: 78.37% // Head: 78.37% // No change to project coverage 👍

Coverage data is based on head (d67fbf9) compared to base (b937d48).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #7390   +/-   ##
========================================
  Coverage    78.37%   78.37%           
========================================
  Files         1647     1647           
  Lines       190327   190327           
========================================
  Hits        149171   149171           
  Misses       41156    41156           

Impacted Files	Coverage Δ
src/goto-symex/goto_symex_state.cpp	91.82% <100.00%> (ø)
src/util/simplify_expr.cpp	85.31% <100.00%> (+0.01%)	⬆️
src/util/pointer_predicates.cpp	92.72% <0.00%> (-0.38%)	⬇️
src/util/ieee_float.cpp	88.06% <0.00%> (-0.17%)	⬇️
src/ansi-c/expr2c.cpp	67.28% <0.00%> (-0.15%)	⬇️
src/ansi-c/c_typecheck_expr.cpp	75.60% <0.00%> (+<0.01%)	⬆️
src/solvers/smt2/smt2_conv.cpp	68.66% <0.00%> (+0.09%)	⬆️
src/solvers/smt2/smt2_format.cpp	86.51% <0.00%> (+1.12%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.