Skip to content

Add --nondet-static-matching regex option #7389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 10, 2023

Conversation

peterschrammel
Copy link
Member

Adds a more general mechanism for selecting which static variables should be initialized nondeterministically.

The regex matches the string consisting of the filename and the variable display name separated by a colon, e.g. "main.c:x", a format that is already used by the nondet_static(goto_model, except_values) variant.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • [n/a] My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • [n/a] White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link
Member

@kroening kroening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Model transformation really should not go into the CBMC binary -- this needs to go into goto-instrument. We want to remove --nondet-static.

@codecov
Copy link

codecov bot commented Nov 26, 2022

Codecov Report

Base: 78.49% // Head: 78.49% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (bee1b9c) compared to base (b5bf362).
Patch coverage: 90.47% of modified lines in pull request are covered.

❗ Current head bee1b9c differs from pull request most recent head 22152fc. Consider uploading reports for the commit 22152fc to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7389   +/-   ##
========================================
  Coverage    78.49%   78.49%           
========================================
  Files         1663     1663           
  Lines       191339   191360   +21     
========================================
+ Hits        150185   150204   +19     
- Misses       41154    41156    +2     
Impacted Files Coverage Δ
...rc/goto-instrument/goto_instrument_parse_options.h 100.00% <ø> (ø)
src/cbmc/cbmc_parse_options.cpp 79.80% <33.33%> (-0.36%) ⬇️
.../goto-instrument/goto_instrument_parse_options.cpp 71.63% <100.00%> (+0.16%) ⬆️
src/goto-instrument/nondet_static.cpp 97.43% <100.00%> (+0.51%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@peterschrammel
Copy link
Member Author

this needs to go into goto-instrument

Alright, agreed.

@giulio-garbi giulio-garbi force-pushed the nondet-static-matching branch 4 times, most recently from bee1b9c to 011937c Compare February 8, 2023 17:54
Adds a more general mechanism for selecting
which static variables should be initialized
nondeterministically.

The regex matches the string consisting of
the filename and the variable display name
separated by a colon, e.g. "main.c:x".
@giulio-garbi giulio-garbi force-pushed the nondet-static-matching branch from 09e3c30 to 2dda8de Compare February 9, 2023 17:12
@giulio-garbi giulio-garbi force-pushed the nondet-static-matching branch from 2dda8de to 22152fc Compare February 9, 2023 17:17
@kroening kroening merged commit 882bd0d into diffblue:develop Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants