Skip to content

Update CODEOWNERS #7387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2022
Merged

Update CODEOWNERS #7387

merged 1 commit into from
Nov 25, 2022

Conversation

jimgrundy
Copy link
Collaborator

This PR would broaden code-ownership for the documentation directory to include some extra folks with broad project responsibilities who should be able to review the quality of documentation. This should accelerate progress when someone makes a documentation change as today that can necessitate review from a small set of people.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Base: 78.35% // Head: 78.37% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (b937d48) compared to base (25c32cc).
Patch coverage: 96.38% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7387      +/-   ##
===========================================
+ Coverage    78.35%   78.37%   +0.01%     
===========================================
  Files         1645     1647       +2     
  Lines       190208   190327     +119     
===========================================
+ Hits        149040   149171     +131     
+ Misses       41168    41156      -12     
Impacted Files Coverage Δ
src/ansi-c/c_typecheck_base.h 100.00% <ø> (ø)
.../goto-instrument/contracts/dynamic-frames/dfcc.cpp 97.56% <83.33%> (+8.25%) ⬆️
src/ansi-c/c_typecheck_expr.cpp 75.59% <93.93%> (+0.24%) ⬆️
src/goto-instrument/contracts/contracts.cpp 95.38% <100.00%> (+0.06%) ⬆️
...ument/contracts/dynamic-frames/dfcc_instrument.cpp 81.12% <100.00%> (+0.16%) ⬆️
...strument/contracts/dynamic-frames/dfcc_library.cpp 95.63% <100.00%> (ø)
...t/contracts/dynamic-frames/dfcc_obeys_contract.cpp 100.00% <100.00%> (ø)
...ent/contracts/dynamic-frames/dfcc_obeys_contract.h 100.00% <100.00%> (ø)
...t/contracts/dynamic-frames/dfcc_spec_functions.cpp 73.65% <100.00%> (+0.43%) ⬆️
...nt/contracts/dynamic-frames/dfcc_swap_and_wrap.cpp 86.36% <100.00%> (ø)
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tautschnig tautschnig merged commit d05a097 into develop Nov 25, 2022
@tautschnig tautschnig deleted the jimgrundy-doco-owners branch November 25, 2022 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants