Skip to content

Cleanup chrono includes #7384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2022

Conversation

tautschnig
Copy link
Collaborator

With Ubuntu 22.04 GitHub runner image 20221119.2 there appears to be some libclang difference so that include-what-you-use newly started suggesting bits/chrono instead of chrono (which is spurious); nevertheless, some of the uses of #include <chrono> indeed were unnecessary.

Fixes: #7383

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig self-assigned this Nov 25, 2022
With Ubuntu 22.04 GitHub runner image 20221119.2 there appears to be
some libclang difference so that include-what-you-use newly started
suggesting `bits/chrono` instead of `chrono` (which is spurious);
nevertheless, some of the uses of `#include <chrono>` indeed were
unnecessary.

Fixes: diffblue#7383
@tautschnig tautschnig force-pushed the cleanup/7383-include-cleanup branch from c50ded5 to 25c32cc Compare November 25, 2022 09:41
@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Base: 78.35% // Head: 78.35% // No change to project coverage 👍

Coverage data is based on head (25c32cc) compared to base (53969bc).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7384   +/-   ##
========================================
  Coverage    78.35%   78.35%           
========================================
  Files         1645     1645           
  Lines       190208   190208           
========================================
  Hits        149040   149040           
  Misses       41168    41168           
Impacted Files Coverage Δ
src/goto-checker/multi_path_symex_checker.cpp 95.65% <ø> (ø)
src/goto-checker/multi_path_symex_only_checker.cpp 100.00% <ø> (ø)
...-checker/single_loop_incremental_symex_checker.cpp 90.82% <ø> (ø)
src/goto-checker/single_path_symex_checker.h 100.00% <ø> (ø)
...rc/goto-checker/single_path_symex_only_checker.cpp 97.53% <ø> (ø)
src/goto-checker/single_path_symex_only_checker.h 100.00% <ø> (ø)
src/goto-checker/symex_coverage.cpp 96.35% <ø> (ø)
src/goto-symex/symex_target_equation.cpp 95.38% <ø> (ø)
src/solvers/prop/prop_conv_solver.cpp 87.50% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tautschnig tautschnig marked this pull request as ready for review November 25, 2022 10:28
@TGWDB TGWDB merged commit d43d0ec into diffblue:develop Nov 25, 2022
@tautschnig tautschnig deleted the cleanup/7383-include-cleanup branch November 25, 2022 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IWYU failing on develop and also fails too early
4 participants