Skip to content

CONTRACTS: Fix conditional havoc code #7380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

remi-delmas-3000
Copy link
Collaborator

Fixes #7379

The condition was being checked on the write set variable instead of write set element variable

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@remi-delmas-3000 remi-delmas-3000 changed the title CONTRACTS: conditional havoc code CONTRACTS: fix conditional havoc code Nov 23, 2022
Copy link
Collaborator

@feliperodri feliperodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo a few clean ups.

@feliperodri feliperodri added bugfix aws Bugs or features of importance to AWS CBMC users aws-high Code Contracts Function and loop contracts labels Nov 23, 2022
@feliperodri feliperodri changed the title CONTRACTS: fix conditional havoc code CONTRACTS: Fix conditional havoc code Nov 23, 2022
@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Base: 78.35% // Head: 78.36% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (6b2a4ee) compared to base (c7550b6).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7380   +/-   ##
========================================
  Coverage    78.35%   78.36%           
========================================
  Files         1645     1645           
  Lines       190182   190247   +65     
========================================
+ Hits        149015   149080   +65     
  Misses       41167    41167           
Impacted Files Coverage Δ
...t/contracts/dynamic-frames/dfcc_spec_functions.cpp 73.07% <100.00%> (-0.15%) ⬇️
src/goto-checker/symex_coverage.cpp 96.35% <0.00%> (ø)
src/goto-programs/goto_convert_class.h 88.15% <0.00%> (ø)
src/goto-checker/single_path_symex_checker.h 100.00% <0.00%> (ø)
src/goto-programs/goto_convert_functions.cpp 100.00% <0.00%> (ø)
src/goto-checker/multi_path_symex_checker.cpp 95.65% <0.00%> (ø)
src/goto-checker/single_path_symex_only_checker.h 100.00% <0.00%> (ø)
src/goto-checker/multi_path_symex_only_checker.cpp 100.00% <0.00%> (ø)
...rc/goto-checker/single_path_symex_only_checker.cpp 97.53% <0.00%> (ø)
...-checker/single_loop_incremental_symex_checker.cpp 90.82% <0.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tautschnig tautschnig removed their assignment Nov 24, 2022
The condition was being checked on the
write set variable instead of write set element
variable
@remi-delmas-3000 remi-delmas-3000 force-pushed the contracts-fix-havoc-codegen branch from 439e412 to 6b2a4ee Compare November 25, 2022 16:16
@tautschnig tautschnig merged commit 40d12b6 into diffblue:develop Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws Bugs or features of importance to AWS CBMC users aws-high bugfix Code Contracts Function and loop contracts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in contract replacement with conditional assings clauses
3 participants