SMT2 backend: minus on void pointers #7338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for p-q for void pointers p and q to the SMT2 backend.
Codecov ReportBase: 78.28% // Head: 78.28% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #7338 +/- ##
========================================
Coverage 78.28% 78.28%
========================================
Files 1642 1642
Lines 189995 190000 +5
========================================
+ Hits 148737 148742 +5
Misses 41258 41258
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
kroening
requested review from
martin-cs,
peterschrammel,
thomasspriggs,
NlightNFotis and
TGWDB
as code owners
3 tasks
thomasspriggs
approved these changes
Nov 14, 2022
| pointer_offset_size(to_pointer_type(expr.op0().type()).base_type(), ns); | ||
| CHECK_RETURN(element_size.has_value() && *element_size >= 1); | ||
| const auto &base_type = to_pointer_type(expr.op0().type()).base_type(); | ||
| mp_integer element_size; |
There was a problem hiding this comment.
🤔 It might be nice if this code which works out the element_size were to be factored out into a separate function. This commit seems to be duplicating the code from pointer addition.
peterschrammel
approved these changes
Nov 15, 2022
TGWDB
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for
p-qfor void pointerspandqto the SMT2 backend.