Skip to content

Simplifier type invariant: add diagnostic information #7332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2022

Conversation

tautschnig
Copy link
Collaborator

With the previous code, an invariant failure did not aid debugging.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

With the previous code, an invariant failure did not aid debugging.
@codecov
Copy link

codecov bot commented Nov 13, 2022

Codecov Report

Base: 78.28% // Head: 78.28% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (d7dd40a) compared to base (9fd95ed).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7332   +/-   ##
========================================
  Coverage    78.28%   78.28%           
========================================
  Files         1642     1642           
  Lines       189992   189995    +3     
========================================
+ Hits        148734   148737    +3     
  Misses       41258    41258           
Impacted Files Coverage Δ
...instrument/contracts/dynamic-frames/dfcc_utils.cpp 95.76% <100.00%> (+0.03%) ⬆️
src/goto-programs/goto_convert.cpp 88.09% <100.00%> (ø)
src/goto-programs/goto_program.h 90.41% <100.00%> (+0.07%) ⬆️
src/util/simplify_expr.cpp 84.42% <100.00%> (ø)
src/goto-instrument/goto_program2code.cpp 68.81% <0.00%> (-0.03%) ⬇️
src/goto-symex/symex_goto.cpp 97.38% <0.00%> (-0.01%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@peterschrammel peterschrammel removed their assignment Nov 13, 2022
@kroening kroening merged commit e5f6077 into diffblue:develop Nov 13, 2022
@tautschnig tautschnig deleted the feature/simp-diagnostics branch November 13, 2022 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants