Skip to content

[CI] Fix windows slack notification. #7314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

NlightNFotis
Copy link
Contributor

We currently have a small go utility to produce some notifications on Diffblue's Open Source team channel on Slack, so that we keep track of the release and any builds for associated artifacts.

The notifications work on Linux, but they required running the go program directly on MacOS, because the action is bootstrapping an Alpine Linux container which for some reason is incompatible with the MacOS and Windows runners.

This commit follows the same recipe (running the go binary directly) to allow us to keep track of the Windows .msi installer package build.

We currently have a small `go` utility to produce some notifications on
Diffblue's Open Source team channel on Slack, so that we keep track
of the release and any builds for associated artifacts.

The notifications work on Linux, but they required running the `go`
program directly on MacOS, because the action is bootstrapping an
Alpine Linux container which for some reason is incompatible with
the MacOS and Windows runners.

This commit follows the same recipe (running the go binary directly)
to allow us to keep track of the Windows `.msi` installer package
build.
@NlightNFotis NlightNFotis added the CI label Nov 9, 2022
@NlightNFotis NlightNFotis self-assigned this Nov 9, 2022
@NlightNFotis NlightNFotis requested a review from a team as a code owner November 9, 2022 23:01
@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Base: 78.26% // Head: 78.28% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (2890f74) compared to base (557624c).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7314      +/-   ##
===========================================
+ Coverage    78.26%   78.28%   +0.01%     
===========================================
  Files         1642     1642              
  Lines       189830   189980     +150     
===========================================
+ Hits        148568   148720     +152     
+ Misses       41262    41260       -2     
Impacted Files Coverage Δ
src/solvers/lowering/byte_operators.cpp 92.76% <100.00%> (+0.02%) ⬆️
...c/solvers/smt2_incremental/convert_expr_to_smt.cpp 82.91% <100.00%> (-0.14%) ⬇️
...ncremental/smt2_incremental_decision_procedure.cpp 96.81% <100.00%> (+0.09%) ⬆️
...t/solvers/smt2_incremental/convert_expr_to_smt.cpp 99.69% <100.00%> (-0.02%) ⬇️
...ncremental/smt2_incremental_decision_procedure.cpp 98.75% <100.00%> (+0.65%) ⬆️
src/solvers/flattening/arrays.cpp 80.37% <0.00%> (+0.53%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@NlightNFotis NlightNFotis merged commit 0229307 into diffblue:develop Nov 10, 2022
@NlightNFotis NlightNFotis deleted the fix_windows_notification_slack branch November 10, 2022 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants