Skip to content

Add unit test of object size tracking for new SMT backend. #7311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

thomasspriggs
Copy link
Contributor

This PR adds unit tests of object size tracking for new SMT backend. We were previously missing unit tests for the tracking of object sizes. Note that this test includes tracking for when object sizes are based on symbols rather than statically defined. This is used for dynamically sized objects such as those pointed to by the return value of malloc.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Because we were previously missing unit tests for the tracking of object
sizes. Note that this test includes tracking for when object sizes are
based on symbols rather than statically defined. This is used for
dynamically sized objects such as those pointed to by the return value
of `malloc`.
@NlightNFotis
Copy link
Contributor

Don't worry about the failing CI, it's a network issue on codecov's end.

@thomasspriggs thomasspriggs merged commit deaa5ee into diffblue:develop Nov 10, 2022
@thomasspriggs thomasspriggs deleted the tas/test_dynamic_object_sizes branch November 10, 2022 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants