Skip to content

Solver stats reporting: fix expression mapping for guards #7309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2022

Conversation

tautschnig
Copy link
Collaborator

When converting guards we convert SSA_stept::guard, and not SSA_stept::cond_expr. This needs to be accounted for in solver stats reporting as we would otherwise misleadingly report that expressions like "true" yield a non-empty set of clauses.

Fixes: #6333

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

When converting guards we convert `SSA_stept::guard`, and not
`SSA_stept::cond_expr`. This needs to be accounted for in solver stats
reporting as we would otherwise misleadingly report that expressions
like "true" yield a non-empty set of clauses.

Fixes: diffblue#6333
@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Base: 78.25% // Head: 78.26% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (557624c) compared to base (d2d3142).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7309   +/-   ##
========================================
  Coverage    78.25%   78.26%           
========================================
  Files         1642     1642           
  Lines       189826   189830    +4     
========================================
+ Hits        148552   148568   +16     
+ Misses       41274    41262   -12     
Impacted Files Coverage Δ
...instrument/contracts/dynamic-frames/dfcc_utils.cpp 95.73% <100.00%> (+0.03%) ⬆️
.../contracts/dynamic-frames/dfcc_wrapper_program.cpp 98.36% <100.00%> (ø)
src/goto-symex/symex_target_equation.cpp 95.38% <100.00%> (+0.02%) ⬆️
src/goto-symex/solver_hardness.cpp 59.00% <0.00%> (+6.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tautschnig tautschnig merged commit b4a4122 into diffblue:develop Nov 8, 2022
@tautschnig tautschnig deleted the bugfixes/6333-solver-stats branch November 8, 2022 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected Clauses for SSA Expression
3 participants