Skip to content

SMT2: implement flattening for arrays #7290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2022
Merged

Conversation

kroening
Copy link
Member

@kroening kroening commented Nov 2, 2022

This adds flattening for arrays into the SMT2 backend, used, for instance, when lowering unions.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Base: 78.03% // Head: 78.05% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (7fa94ab) compared to base (21e3260).
Patch coverage: 96.42% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7290      +/-   ##
===========================================
+ Coverage    78.03%   78.05%   +0.01%     
===========================================
  Files         1624     1624              
  Lines       187405   187422      +17     
===========================================
+ Hits        146249   146289      +40     
+ Misses       41156    41133      -23     
Impacted Files Coverage Δ
src/solvers/flattening/boolbv_width.cpp 73.80% <0.00%> (ø)
src/ansi-c/expr2c.cpp 67.35% <100.00%> (+0.03%) ⬆️
src/goto-programs/goto_clean_expr.cpp 99.02% <100.00%> (ø)
src/goto-programs/goto_convert_side_effect.cpp 94.50% <100.00%> (+0.02%) ⬆️
src/goto-symex/goto_symex.cpp 98.64% <100.00%> (ø)
src/solvers/smt2/smt2_conv.cpp 66.36% <100.00%> (+0.88%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

This adds flattening for arrays into the SMT2 backend, used, for instance,
when lowering unions.
@kroening kroening force-pushed the smt2-array-flattening branch from 6bfdc54 to 7fa94ab Compare November 2, 2022 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants