add three tests for unions in structs #7278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterschrammel
approved these changes
Oct 27, 2022
Codecov ReportBase: 78.03% // Head: 78.03% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## develop #7278 +/- ##
========================================
Coverage 78.03% 78.03%
========================================
Files 1624 1624
Lines 187405 187405
========================================
Hits 146249 146249
Misses 41156 41156 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
tautschnig
reviewed
Oct 27, 2022
regression/cbmc/union/union_member.c
Outdated
Comment on lines
1
to
15
| #include <assert.h> | ||
|
|
||
| struct s { | ||
| union U { | ||
| char b[2]; | ||
| }; | ||
| }; | ||
|
|
||
| int main() { | ||
| struct s X; | ||
| __CPROVER_assert(X.b[1] == 2, "should fail"); | ||
| } |
There was a problem hiding this comment.
Won't fail anymore with #7230, but even now only fails with z3. Works fine with the in-tree SMT solver.
regression/cbmc/union/union_update.c
Outdated
Comment on lines
1
to
16
| #include <assert.h> | ||
|
|
||
| struct s { | ||
| char a; | ||
| union U { | ||
| char c; | ||
| char b[2]; | ||
| } u; | ||
| } X = { 1, 2 }; | ||
|
|
||
| int main() { | ||
| __CPROVER_assert(X.u.b[1] == 123, "should fail"); | ||
| } |
There was a problem hiding this comment.
Only fails with z3, works fine with the in-tree SMT solver.
These tests pass with the built-in solver but fail with three different errors when using SMT.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests pass with the built-in solver but fail with three different errors when using SMT.