Field sensitivity: using apply is now always safe #7259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
requested review from
peterschrammel and
romainbrenguier
as code owners
Codecov ReportBase: 78.00% // Head: 78.01% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #7259 +/- ##
========================================
Coverage 78.00% 78.01%
========================================
Files 1621 1623 +2
Lines 187273 187299 +26
========================================
+ Hits 146089 146113 +24
- Misses 41184 41186 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
With the changes from 6193534 it is safe to call `apply` even when doing field assignments: the right-hand side will not be a divisible compound (which we previously sought to protect from field expansion). This makes field sensitivity stateless, and all methods are `const`. They are not static, however, as the constructor initialises configuration options (which would otherwise need to be passed to each call). We can then also avoid a level of indirection through `apply` and call `get_fields` directly in two cases.
tautschnig
force-pushed
the
cleanup/fs-stateless
branch
from
0186720 to
aa3cbd8
Compare
peterschrammel
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the changes from 6193534 it is safe to call
applyeven when doing field assignments: the right-hand side will not be a divisible compound (which we previously sought to protect from field expansion).This makes field sensitivity stateless, and all methods are
const. They are not static, however, as the constructor initialises configuration options (which would otherwise need to be passed to each call).We can then also avoid a level of indirection through
applyand callget_fieldsdirectly in two cases.