Skip to content

External SAT back-end: handle whitespace at end of line gracefully #7222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 8, 2022

Conversation

tautschnig
Copy link
Collaborator

CryptoMiniSat produces assignment output that includes whitespace at the end of the line. Strip such (empty) elements before evaluating entries as literals.

Fixes: #7164

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

CryptoMiniSat produces assignment output that includes whitespace at the
end of the line. Strip such (empty) elements before evaluating entries
as literals.

Fixes: diffblue#7164
@codecov
Copy link

codecov bot commented Oct 8, 2022

Codecov Report

Base: 77.89% // Head: 77.91% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (eb01891) compared to base (8115bb9).
Patch coverage: 76.99% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7222      +/-   ##
===========================================
+ Coverage    77.89%   77.91%   +0.02%     
===========================================
  Files         1616     1616              
  Lines       186791   186797       +6     
===========================================
+ Hits        145498   145549      +51     
+ Misses       41293    41248      -45     
Impacted Files Coverage Δ
.../src/java_bytecode/java_bytecode_convert_class.cpp 94.18% <ø> (ø)
...src/java_bytecode/java_bytecode_convert_method.cpp 97.69% <ø> (ø)
jbmc/src/java_bytecode/java_bytecode_language.cpp 92.81% <ø> (ø)
jbmc/src/java_bytecode/java_object_factory.cpp 94.40% <ø> (ø)
jbmc/src/java_bytecode/java_string_literals.cpp 94.54% <ø> (ø)
src/analyses/cfg_dominators.h 100.00% <ø> (ø)
...le-sensitivity/value_set_pointer_abstract_object.h 100.00% <ø> (ø)
src/ansi-c/ansi_c_convert_type.h 100.00% <ø> (ø)
src/ansi-c/ansi_c_internal_additions.cpp 90.12% <ø> (ø)
src/ansi-c/c_typecheck_base.h 100.00% <ø> (ø)
... and 43 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tautschnig tautschnig force-pushed the bugfixes/7164-space branch 2 times, most recently from 9195be8 to 4a88215 Compare October 8, 2022 13:34
@tautschnig tautschnig self-assigned this Oct 8, 2022
@tautschnig tautschnig force-pushed the bugfixes/7164-space branch 4 times, most recently from abf760a to 236aaeb Compare October 8, 2022 15:08
@tautschnig tautschnig marked this pull request as draft October 8, 2022 15:31
The test uses Z3 as this is a tool we expect to be installed in other
regression tests anyway.
@tautschnig tautschnig force-pushed the bugfixes/7164-space branch from 236aaeb to eb01891 Compare October 8, 2022 15:34
@tautschnig tautschnig marked this pull request as ready for review October 8, 2022 20:05
@tautschnig tautschnig merged commit 77d7af0 into diffblue:develop Oct 8, 2022
@tautschnig tautschnig deleted the bugfixes/7164-space branch October 8, 2022 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception when processing SAT assignment with cryptominisat
4 participants