CONTRACTS: Allow void function calls in assigns clauses #7214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Front-end modification that prepares for dynamic frames.
remi-delmas-3000
requested review from
tautschnig,
feliperodri,
kroening and
chris-ryder
as code owners
kroening
approved these changes
Oct 6, 2022
|
@nwetzler, can you review the front-end changes. |
Codecov ReportBase: 77.89% // Head: 77.88% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #7214 +/- ##
===========================================
- Coverage 77.89% 77.88% -0.01%
===========================================
Files 1616 1616
Lines 186701 186719 +18
===========================================
+ Hits 145433 145435 +2
- Misses 41268 41284 +16
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
feliperodri
changed the title
feliperodri
approved these changes
Oct 6, 2022
Comment on lines
+1000
to
+1002
| throw invalid_source_file_exceptiont( | ||
| "function pointer calls not allowed in assigns clauses", | ||
| target.source_location()); |
There was a problem hiding this comment.
Could we add a regression test to cover this case?
Comment on lines
+1022
to
+1023
| "to " CPROVER_PREFIX | ||
| "POINTER_OBJECT or a call to a function returning void", |
There was a problem hiding this comment.
Why do we need to remove here all CPROVER_PREFIX_object_* cases? Make the error message shorter? For me, it was quite informative before.
nwetzler
approved these changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a front-end modification required for #6887. It allows to call user-defined functions returning void in
assigns clauses.
Accepted by the front end but triggers an error in the back end if actually used (for now).
Will be documented when supported.