C front-end: floating-point built-ins are in the symbol table #7175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
requested review from
kroening and
peterschrammel
as code owners
Codecov ReportBase: 78.38% // Head: 78.36% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #7175 +/- ##
===========================================
- Coverage 78.38% 78.36% -0.03%
===========================================
Files 1647 1647
Lines 190343 189941 -402
===========================================
- Hits 149196 148842 -354
+ Misses 41147 41099 -48
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
martin-cs
approved these changes
Oct 3, 2022
nwetzler
approved these changes
Oct 5, 2022
tautschnig
force-pushed
the
cleanup/float-builtin
branch
from
d215c1c to
83c1fbf
Compare
tautschnig
force-pushed
the
cleanup/float-builtin
branch
3 times, most recently
from
457cdde to
34dad4b
Compare
It should never be the case that no symbol for `__CPROVER_isgreaterf`, `__CPROVER_isgreaterd` and similar floating-point built-ins is present for these are declared in cprover_builtin_headers.h. This commit removes dead code and adds an additional consistency check.
tautschnig
force-pushed
the
cleanup/float-builtin
branch
from
34dad4b to
fad8023
Compare
peterschrammel
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should never be the case that no symbol for
__CPROVER_isgreaterf,__CPROVER_isgreaterdand similar floating-point built-ins is present for these are declared in cprover_builtin_headers.h. This commit removes dead code and adds an additional consistency check.