Skip to content

Remove deprecated variants of exprt::{add,copy}_to_operands #7154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

tautschnig
Copy link
Collaborator

These were deprecated in 8dde888 and are no longer used.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • n/a Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

These were deprecated in 8dde888 and are no longer used.
@tautschnig tautschnig assigned tautschnig and unassigned kroening Sep 26, 2022
@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Base: 77.88% // Head: 77.88% // No change to project coverage 👍

Coverage data is based on head (75d0513) compared to base (ee0a06d).
Patch coverage: 90.54% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7154   +/-   ##
========================================
  Coverage    77.88%   77.88%           
========================================
  Files         1576     1576           
  Lines       181867   181867           
========================================
  Hits        141645   141645           
  Misses       40222    40222           
Impacted Files Coverage Δ
src/ansi-c/expr2c.cpp 67.13% <ø> (ø)
src/goto-programs/restrict_function_pointers.h 100.00% <ø> (ø)
src/goto-programs/validate_goto_model.h 100.00% <ø> (ø)
src/util/expr.h 97.02% <ø> (ø)
src/util/format_expr.cpp 86.89% <0.00%> (ø)
src/util/simplify_expr_class.h 90.47% <ø> (ø)
unit/goto-programs/goto_program_validate.cpp 100.00% <ø> (ø)
src/goto-programs/restrict_function_pointers.cpp 82.15% <50.00%> (ø)
src/ansi-c/c_typecheck_expr.cpp 74.19% <72.72%> (ø)
src/crangler/c_wrangler.cpp 75.51% <100.00%> (ø)
... and 23 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tautschnig tautschnig merged commit 8b5d37a into diffblue:develop Sep 26, 2022
@tautschnig tautschnig deleted the cleanup/remove-deprecated-exprt-methods branch September 26, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants